Overwrite all files when not in non interactive mode #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
changed the title
maxhelias
approved these changes
Jan 23, 2023
stof
reviewed
Apr 8, 2025
| @@ -68,7 +68,7 @@ public function shouldWriteFile(string $file, bool $overwrite): bool | |||
| exec('git status --short --ignored --untracked-files=all -- '.ProcessExecutor::escape($file).' 2>&1', $output, $status); | |||
|
|
|||
| if (0 !== $status) { | |||
| return $this->io && $this->io->askConfirmation(sprintf('Cannot determine the state of the "%s" file, overwrite anyway? [y/N] ', $file), false); | |||
| return $this->io && $this->io->askConfirmation(sprintf('Cannot determine the state of the "%s" file, overwrite anyway? [y/N] ', $file)); | |||
There was a problem hiding this comment.
you should change which of the y and n is a capital letter to reflect the default, so that users will know what will happen if they press Enter without writing any letter.
|
Note that this default should impact only files for which git cannot give us the modified state or untracked files. Existing files created by recipes are supposed to be tracked files. What is your workflow in which no files are being overwritten ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
recipes:install --reset --force -nno files are overwritten, as the default as been set to false.There is currently also no way to accept that, so I changed it back to
true