Regenerate doesn't work if there is an Embedded property in Entity

[welcoMattic]

Hi, thanks for maker-bundle, it's a very powerful tool! ❤️

I tried to regenerate an Entity that contains a @ORM\Embedded() property.

Here the steps to reproduce the bug:

• Run make:entity with some fields
• Add a @ORM\Embedded() property to this entity
• Try to regenerate the entity getters/setters

💥

The output is:

$ bin/console make:entity --regenerate --overwrite

 This command will generate any missing methods (e.g. getters & setters) for a class or all classes in a namespace.

 To overwrite any existing methods, re-run this command with the --overwrite flag

 Enter a class or namespace to regenerate [App\Entity]:
 > App\Entity\Product


In ClassMetadataInfo.php line 3325:

  Notice: Trying to get property 'name' of non-object

[welcoMattic]

In fact, make:form fails too if I try to generate a form.

bin/console make:form

 The name of the form class (e.g. TinyPuppyType):
 > FooType


In ClassMetadataInfo.php line 3325:

  Notice: Trying to get property 'name' of non-object

[sadikoff]

@welcoMattic Could you please provide your Entity mapping and check your maker-bundle version, I cannot reproduce this bug

[welcoMattic]

Product.php (Generated entity)

namespace App\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\HttpFoundation\File\File;
use Vich\UploaderBundle\Mapping\Annotation as Vich;

/**
 * @ORM\Entity()
 * @Vich\Uploadable
 */
class Product
{
    /**
     * @ORM\Id()
     * @ORM\GeneratedValue()
     * @ORM\Column(type="integer")
     */
    private $id;

    /**
     * @ORM\Column(type="string", length=255, unique=true)
     */
    private $reference;

    /**
     * @ORM\Column(type="string", length=255)
     */
    private $designation;

    /**
     * @ORM\Embedded(class="CatalogMedia")
     */
    private $mainMedia;

    ...

}

CatalogMedia (Embeddable)

<?php

namespace App\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\HttpFoundation\File\File;
use Vich\UploaderBundle\Mapping\Annotation as Vich;

/**
 * @ORM\Embeddable()
 * @Vich\Uploadable
 */
class CatalogMedia
{
    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    private $filename;

    /**
     * @Vich\UploadableField(mapping="catalog_media", fileNameProperty="filename")
     */
    private $file;

    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    private $altAttribute;

    ...
}

If execute make:entity --regenerate --overwrite now, there will throw an error.

[weaverryan]

Hey @welcoMattic!

Thanks for the ♥️ - that's our goal!

Can you verify exactly what version of MakerBundle you're using? We thought we squashed this bug in #149, which was included in v1.4.1.

Cheers!

[welcoMattic]

Hi @weaverryan!

I just updated the bundle to 1.4.2, and I still get the error message.

Here's the complete output of $ bin/console make:entity --regenerate --overwrite -vvv:

This command will generate any missing methods (e.g. getters & setters) for a class or all classes in a namespace.

To overwrite any existing methods, re-run this command with the --overwrite flag

Enter a class or namespace to regenerate [App\Entity]:
> App\Entity\Product


In ClassMetadataInfo.php line 3325:

[ErrorException]
Notice: Trying to get property 'name' of non-object


Exception trace:
Doctrine\ORM\Mapping\ClassMetadataInfo->inlineEmbeddable() at /my_project/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:194
Doctrine\ORM\Mapping\ClassMetadataFactory->doLoadMetadata() at /my_project/vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:333
Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory->loadMetadata() at /my_project/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php:78
Doctrine\ORM\Mapping\ClassMetadataFactory->loadMetadata() at /my_project/vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:226
Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory->getMetadataFor() at /my_project/vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php:115
Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory->getAllMetadata() at /my_project/vendor/symfony/maker-bundle/src/Doctrine/DoctrineHelper.php:124
Symfony\Bundle\MakerBundle\Doctrine\DoctrineHelper->getMetadata() at /my_project/vendor/symfony/maker-bundle/src/Doctrine/EntityRegenerator.php:43
Symfony\Bundle\MakerBundle\Doctrine\EntityRegenerator->regenerateEntities() at /my_project/vendor/symfony/maker-bundle/src/Maker/MakeEntity.php:778
Symfony\Bundle\MakerBundle\Maker\MakeEntity->regenerateEntities() at /my_project/vendor/symfony/maker-bundle/src/Maker/MakeEntity.php:121
Symfony\Bundle\MakerBundle\Maker\MakeEntity->generate() at /my_project/vendor/symfony/maker-bundle/src/Command/MakerCommand.php:93
Symfony\Bundle\MakerBundle\Command\MakerCommand->execute() at /my_project/vendor/symfony/console/Command/Command.php:252
Symfony\Component\Console\Command\Command->run() at /my_project/vendor/symfony/console/Application.php:883
Symfony\Component\Console\Application->doRunCommand() at /my_project/vendor/symfony/framework-bundle/Console/Application.php:86
Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /my_project/vendor/symfony/console/Application.php:241
Symfony\Component\Console\Application->doRun() at /my_project/vendor/symfony/framework-bundle/Console/Application.php:74
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /my_project/vendor/symfony/console/Application.php:143
Symfony\Component\Console\Application->run() at /my_project/bin/console:39

make:entity [--regenerate] [--overwrite] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command> [<name>]

The error comes from doctrine/orm ClassMetadataFactory class. I'm looking for a schema error on my own code 🤔

EDIT: After some of dump, I found that my embedded class CatalogMedia doesn't have reflClass property set. However, doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php need this property in inlineEmbeddable (line 3308 of ClassMetadataInfo.php).

[sadikoff]

I'll check this problem with metedata.

However there is another bug with embedded classes, it refers to embedded field names.

[welcoMattic]

I finally found the cause of this error, and it's not caused by the previous entities. But, by these:

namespace App\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\HttpFoundation\File\File;
use Vich\UploaderBundle\Mapping\Annotation as Vich;

/**
 * @ORM\Embeddable()
 * @Vich\Uploadable
 */
class CatalogMedia
{
    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    private $filename;

    /**
     * @Vich\UploadableField(mapping="catalog_media", fileNameProperty="filename")
     */
    private $file;

    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    private $altAttribute;

    // classic getters and setters
}

and

namespace App\Entity;

use Doctrine\ORM\Mapping as ORM;
use Knp\DoctrineBehaviors\Model as ORMBehaviors;
use Symfony\Component\HttpFoundation\File\File;

/**
 * @ORM\Entity(repositoryClass="App\Repository\CarouselProductMediaRepository")
 */
class CarouselProductMedia
{
    use ORMBehaviors\Timestampable\Timestampable;

    /**
     * @ORM\Id()
     * @ORM\GeneratedValue()
     * @ORM\Column(type="integer")
     */
    private $id;

    /**
     * @ORM\Embedded(class="CatalogMedia")
     */
    private $productMedia;

    public function getId(): ?int
    {
        return $this->id;
    }

    public function getProductMedia(): ?CatalogMedia
    {
        return $this->productMedia;
    }

    public function setProductMedia(?CatalogMedia $productMedia): self
    {
        $this->productMedia = $productMedia;

        if ($this->productMedia->getFile() instanceof File) {
            $this->setUpdatedAt(new \DateTime());
        }

        return $this;
    }
}

May be these entities could help us to fix the issue ;)

[dimabory]

@welcoMattic Hi

Sorry, but I don't see how you have resolved an issue. I configured classes in the same way like you, but still getting error Notice: Trying to get property of non-object.

Can you explain in details?

Thanks!

[welcoMattic]

Hi @dimabory, I haven't fix the issue yet. I'm still working on it on my free time ;)

[magnetik]

Facing the same issue, when using make:entity even without regenerate as long as one entity of the bundle has a embedded property.

[sadikoff]

@welcoMattic hi, can you please test my bugfix?

[welcoMattic]

@sadikoff I'll try do test your bug fix this week (next Tuesday is off in France ;) )

[weaverryan]

@welcoMattic Would you expect the class to be generated with a setter method for your embeddable field? Or, only a getter? (because, the embeddable is initialized in the constructor, so technically, a setter is not needed)

[welcoMattic]

@weaverryan I expect neither getter or setter, just regeneration without errors. Then if we can pass an option to generate a getter for embeddable, it's perfect ;)