Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Tests & Various Fixes for Symfony 6 #1010

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Nov 13, 2021

Hi!

A big, kind of ugly change. Reasons:

  • We needed a bit more flexibility to tweak the workflow of individual tests for different versions of Symfony
  • Reduced duplication: the "fixtures" in the tests caused a lot of duplication, which has grown over time. This minimizes that quite a lot.

Fixes #1009, fixes #1005, fixes #984, fixes #900

Cheers!

.github/workflows/ci.yaml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Maker/MakeRegistrationForm.php Outdated Show resolved Hide resolved
src/Test/MakerTestRunner.php Outdated Show resolved Hide resolved
src/Test/MakerTestRunner.php Outdated Show resolved Hide resolved
@weaverryan weaverryan marked this pull request as ready for review November 16, 2021 01:57
@weaverryan weaverryan changed the title [WIP] Refactoring Tests Refactoring Tests & Various Fixes for Symfony 6 Nov 16, 2021
@weaverryan
Copy link
Member Author

This is ready! Though I don't seriously expect any detailed review :).

This is HUGE - sorry. It is 95% test refactoring and 3% fixing our test matrix to test a wider variety of Symfony versions and 2% fixing minor real bugs for different versions of Symfony that these enhanced matrix found.

The remaining failures for Symfony 6 are due to 10 tests where the package we're testing is not yet installable on Symfony 6. So, not much we can do there :). Those tests should start passing when those packages add Sf6 compat. If they continue failing, we'll then know we have a bug to track down.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants