Refactoring Tests & Various Fixes for Symfony 6 #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 15, 2021
weaverryan
changed the title
|
This is ready! Though I don't seriously expect any detailed review :). This is HUGE - sorry. It is 95% test refactoring and 3% fixing our test matrix to test a wider variety of Symfony versions and 2% fixing minor real bugs for different versions of Symfony that these enhanced matrix found. The remaining failures for Symfony 6 are due to 10 tests where the package we're testing is not yet installable on Symfony 6. So, not much we can do there :). Those tests should start passing when those packages add Sf6 compat. If they continue failing, we'll then know we have a bug to track down. Cheers! |
weaverryan
force-pushed
the
test-refactoring
branch
from
76dc67b to
ed95e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A big, kind of ugly change. Reasons:
Fixes #1009, fixes #1005, fixes #984, fixes #900
Cheers!