Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make:auth #1025

Closed
wants to merge 1 commit into from
Closed

fix make:auth #1025

wants to merge 1 commit into from

Conversation

sinus22
Copy link

@sinus22 sinus22 commented Nov 30, 2021

No description provided.

@weaverryan
Copy link
Member

Hey @sinus22!

Thanks for opening this :). Unfortunately, the fix isn't quite correct - this method ONLY applied to the old Guard authentication. To basically, we just need to make it NOT explode (or not be called at all) when the user is using the new authenticator system. See #1026.

But, thanks again for opening this - it's a critical bug I want to get fixed!

@weaverryan weaverryan closed this Dec 1, 2021
@sinus22 sinus22 deleted the patch-1 branch December 2, 2021 15:03
@jrushlow jrushlow added the Bug Bug Fix label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants