Add @extends tag to Doctrine repository template.
#1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhamon
force-pushed
the
feature/generate-extends-phpdoc-tag-doctrine-entity
branch
from
918e3d7
to
d2ba22b
Compare
hhamon
force-pushed
the
feature/generate-extends-phpdoc-tag-doctrine-entity
branch
from
d2ba22b
to
73b5aee
Compare
|
@weaverryan @kbond ready for review :) |
kbond
approved these changes
Apr 3, 2022
weaverryan
approved these changes
Apr 5, 2022
|
Thanks Hugo! |
Merged
weaverryan
added a commit
that referenced
this pull request
Jul 10, 2023
…y template (gremo) This PR was merged into the 1.0-dev branch. Discussion ---------- Add conditional `@implements` tag to Doctrine repository template Adding the `@implements` phpdoc tag on generated Doctrine repository classes will help IDE and prevent tools like phpstan from generating errors. `@implements` is only added if `$with_password_upgrade` is set to true, avoiding useless phpdocs.  Similar to #1088 Commits ------- dd3208f Add conditional `@implements` tag to Doctrine repository template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
@extendsphpdoc tag on generated Doctrine repository classes will prevent phpstan from generating an error when it's installed in the project.