New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:entity] Improve uid support #1139

Merged

jrushlow merged 2 commits into symfony:main from HypeMC:improve-uid-support

Jul 5, 2022

Contributor

HypeMC commented Jun 15, 2022

Currently uuid is offered as the default type when the field name is uuid, which breaks when the symfony/uid component is not installed. Now guid is used when uuid is not available.
Getters & setters for uuid/ulid types now have type hints added when generated.

HypeMC added 2 commits

June 15, 2022 22:11


          Don't use uuid as default if type does not exist

78487d8


          Add type hints for uuid & ulid types

c056a83

HypeMC force-pushed the improve-uid-support branch from 3e1036f to c056a83 Compare

June 22, 2022 22:29

jrushlow added the Feature label

jrushlow approved these changes

View reviewed changes

Collaborator

jrushlow left a comment

Thank you @HypeMC

jrushlow merged commit b23178c into symfony:main

HypeMC deleted the improve-uid-support branch

July 5, 2022 16:20

jrushlow mentioned this pull request

[git-released] v1.44.0 #1150

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature