Type hints for repositories #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
I like this! And putting all PHPdocs in the class makes it really concise. Thanks @enleur.
|
Should I fix code style? |
|
Yes please :). Unless it’s recommending to use array() instead of [] - that is currently a false recommendation (we use the short syntax) |
|
Done |
|
Thank you Sergey! |
weaverryan
added a commit
that referenced
this pull request
Feb 8, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- Type hints for repositories It helps IDE to get correct type if you do calls like this ```php $user = $this->userRepository->find(1); $user->getId(); //IDE knows that this is a User class and gives correct autocomplete ``` Commits ------- e7dfff0 Add type hints for repository templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps IDE to get correct type if you do calls like this