Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] Add PHPDoc var type for Collections #1219

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

b1rdex
Copy link
Contributor

@b1rdex b1rdex commented Oct 6, 2022

No description provided.

@jrushlow jrushlow added Feature New Feature Status: Needs Review Needs to be reviewed labels Nov 8, 2022
@b1rdex

This comment was marked as outdated.

@pkly
Copy link

pkly commented Mar 28, 2024

Could this be merged in please? I would like to see this feature implemented.

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 28, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @b1rdex - Sorry for the delay... Green tests and I'll merge today

@jrushlow jrushlow merged commit fd6b34a into symfony:main Mar 28, 2024
6 checks passed
@b1rdex b1rdex deleted the collection-var-typehint branch March 28, 2024 12:38
@jrushlow jrushlow mentioned this pull request Apr 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants