[make:registration] Make router optional in MakeRegistrationForm constructor #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
commented
Oct 23, 2022
| @@ -111,6 +111,10 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma | |||
| { | |||
| $interactiveSecurityHelper = new InteractiveSecurityHelper(); | |||
|
|
|||
| if (null === $this->router) { | |||
| throw new RuntimeCommandException('Router have been explicitely disabled in your configuration. This command needs to use the router.'); | |||
There was a problem hiding this comment.
Help welcome to choose a clearer message.
There was a problem hiding this comment.
Looks good enough to me - especially for this edge-case
|
Ah, so you can't run maker at all in your console app? That makes sense - I don't normally think about the router service not being available, but that seems legal to me. |
weaverryan
approved these changes
Oct 25, 2022
| private DoctrineHelper $doctrineHelper, | ||
| private ?RouterInterface $router = null, |
There was a problem hiding this comment.
Class is internal, so no problems changing args 👍
| @@ -111,6 +111,10 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma | |||
| { | |||
| $interactiveSecurityHelper = new InteractiveSecurityHelper(); | |||
|
|
|||
| if (null === $this->router) { | |||
| throw new RuntimeCommandException('Router have been explicitely disabled in your configuration. This command needs to use the router.'); | |||
There was a problem hiding this comment.
Looks good enough to me - especially for this edge-case
jrushlow
changed the title
jrushlow
approved these changes
Nov 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a console application, I have the following configuration:
As the
MakeRegistrationFormclass need aRouterInterfaceto be constructed, I get the following error:Symfony\Bundle\MakerBundle\Maker\MakeRegistrationForm::__construct(): Argument #3 ($router) must be of type Symfony\Component\Routing\RouterInterface, null givenThis PR aim to remove this dependency.