[make:serializer:normalizer] Inject a NormalizerInterface instead of an ObjectNormalizer #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarld
force-pushed
the
fix/normalizer
branch
from
1974d3c
to
70f7079
Compare
|
Actually, after talking with @chalasr, we went to the conclusion that it is better to inject the Therefore, this PR was updated to:
|
mtarld
changed the title
chalasr
approved these changes
Jan 20, 2023
jrushlow
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1252
This PR aims to do not rely anymore on constructor argument injection and use
NormalizerAwareInterface/NormalizerAwareTraitinstead.Moreover, this allows to not inject explicitly the
ObjectNormalizeranymore which can be considered as a bad practice as it is a concrete implementation of theNormalizerInterface.