Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating UUID id fields in entities #1329

Merged
merged 11 commits into from
Mar 22, 2024

Conversation

Coffee2CodeNL
Copy link
Contributor

Related issues: #1037 #1033 #745

@Coffee2CodeNL
Copy link
Contributor Author

Feel free to treat this like a stub for further work

Tests are shoddy at best.

@flkasper
Copy link

flkasper commented Aug 6, 2023

Suggestion for improving this PR:

@Coffee2CodeNL
Copy link
Contributor Author

@flkasper good idea

@flkasper
Copy link

flkasper commented Aug 6, 2023

Another suggestion for improvement that I had forgotten:

class Configuration implements ConfigurationInterface

New project based config in config/packages/dev/maker.yaml entity.uuid_ids: boolean to globally enable uuid generation in the project and evaluate it in make:entity.

@jrushlow jrushlow added the Feature New Feature label Feb 16, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good @Coffee2CodeNL! I have not looked to closely at the tests yet, if you can rebase this PR - we can work on getting those tests green! Thanks in advance...

src/Doctrine/EntityClassGenerator.php Outdated Show resolved Hide resolved
src/Doctrine/EntityClassGenerator.php Outdated Show resolved Hide resolved
src/Maker/MakeUser.php Outdated Show resolved Hide resolved
@jrushlow jrushlow removed the Status: Waiting Feedback Needs feedback from the author label Mar 20, 2024
@jrushlow jrushlow merged commit 970f4c0 into symfony:main Mar 22, 2024
6 checks passed
@jrushlow jrushlow mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Work Additional work is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants