Fix expected variable type #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! This is an absolutely wonderful PR! Fixed the bug & a great test. Thank you @IndraGunawan! |
weaverryan
added a commit
that referenced
this pull request
Mar 21, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- Fix expected variable type error when run `doctrine:schema:update --dump-sql` after creating entity using maker-bundle because of the attribute type error. for example when generate field with length 100 the annotation will be generate like this `@ORM\Column(type="string", length="100", nullable=true)` and when run the schema update command will throw exception ``` In AnnotationException.php line 83: [Type Error] Attribute "length" of @Orm\Column declared on property App\Entity\Entity::$field expects a(n) integer, but got string. ``` and it is also affect for `precision` and `scale` Commits ------- 7f16f06 Fix expected variable type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error when run
doctrine:schema:update --dump-sqlafter creating entity using maker-bundle because of the attribute type error.for example when generate field with length 100 the annotation will be generate like this
@ORM\Column(type="string", length="100", nullable=true)and when run the schema update command will throw exceptionand it is also affect for
precisionandscale