[make:*] upgrade bundled PHP-CS-Fixer to v3.49.0 #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
feature/upgrade-php-cs-fixer
branch
2 times, most recently
from
9712fe7
to
51e2902
Compare
jrushlow
changed the title
jrushlow
added
Feature
jrushlow
force-pushed
the
feature/upgrade-php-cs-fixer
branch
from
2401cb5
to
de2a364
Compare
Merged
theofidry
reviewed
Jun 25, 2024
| public function testPhpCsFixerVersion(): void | ||
| { | ||
| if (str_contains(strtolower(\PHP_OS), 'win')) { | ||
| $this->markTestSkipped('Test only runs on linux.'); |
There was a problem hiding this comment.
this statement is incorrect, for OSX PHP_OS = 'Darwin' which also contains 'win'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateLinterTest::testPhpCsFixerVersion) to ensurephp-cs-fixer -Vmatches the expectedTemplateLinter::BUNDLED_PHP_CS_FIXER_VERSIONconst that must match the actual binary file name. (php-cs-fixer-v.9.9.9.phar