Remove mentions of undefined Doctrine constants Types::ARRAY and Types::OBJECT #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if someone still uses DBAL 3 and relies on those deprecated types? |
|
I suggest putting the type name as a string for those instead of removing them entirely for those legacy types (as done for the |
|
You're right! I've added backward compatibility. I just thought that adding the BC for something that has already been deprecated in the past is not really worth it in the maker bundle. |
derrabus
approved these changes
Feb 5, 2024
|
Thanks @njutn95! We're working on the test failures - it looks like the started exploding with the new Doctrine releases 🤔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437
This PR removes the use of
Types::ARRAYandTypes::OBJECTas they were removed in Doctrine v4.0 (see doctrine/dbal@763b4ad).