[make:user] handle ORM\Column.unique deprecation - use ORM\UniqueConstrain #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
requested changes
Feb 27, 2024
jrushlow
changed the title
maelanleborgne
force-pushed
the
feature/remove-unique-from-user-identifier
branch
from
7c297fa
to
b4b9710
Compare
Co-authored-by: Jesse Rushlow <40327885+jrushlow@users.noreply.github.com>
maelanleborgne
force-pushed
the
feature/remove-unique-from-user-identifier
branch
from
b4b9710
to
0999c89
Compare
jrushlow
approved these changes
Feb 27, 2024
jrushlow
added
Status: Reviewed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of doctrine/dbal#5656, we should stop using the
uniqueproperty of theORM\Columnattribute in themake:usercommand and prefer theORM\UniqueConstraint.This PR should solve this problem 🙂