Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:auth] Fix 'always-remember-me' param always set to true #1461

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[make:auth] Fix 'always-remember-me' param always set to true #1461

merged 1 commit into from
Feb 27, 2024

Conversation

maelanleborgne
Copy link
Contributor

Fixes #1412 and adds test to prevent regression

jrushlow
jrushlow approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maelanleborgne

@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels Feb 27, 2024
@jrushlow jrushlow merged commit e44c1b2 into symfony:main Feb 27, 2024
6 checks passed
@jrushlow jrushlow mentioned this pull request Mar 4, 2024
Merged
@maelanleborgne maelanleborgne deleted the hotfix/fix-remember-me branch April 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make:auth remember_me strategy is always set to "Always activate remember me"
2 participants
@maelanleborgne @jrushlow