Ignorning tests so it is not downloaded via Composer #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this library, the tests do *not* contain example usage code, as most of the classes are internal. By not packing the tests/ directory, we avoid polluting the user's project with extra User classes (etc) that confuse IDE's
javiereguiluz
approved these changes
Apr 3, 2018
|
Thanks Ryan! I agree that it makes sense to make an exception about Symfony's policy in this repo. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 3, 2018
…erryan) This PR was merged into the 1.0-dev branch. Discussion ---------- Ignorning tests so it is not downloaded via Composer This is different than the policy in symfony/symfony. But, this library is a bit different: the tests do *not* contain example usage code, as most of the classes are internal. By not packing the tests/ directory, we avoid polluting the user's project with extra User classes (etc) that confuse IDE's. Fixes #144 Commits ------- a00db1f Ignorning tests so it is not downloaded via Composer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is different than the policy in symfony/symfony. But, this library is a bit different: the tests do not contain example usage code, as most of the classes are internal. By not packing the tests/ directory, we avoid polluting the user's project with extra User classes (etc) that confuse IDE's.
Fixes #144