[make:entity] fix: add failing tests #1480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madflow
commented
Mar 15, 2024
madflow
commented
- Adds failing tests for [make:entity] Cannot create an entity called "Locale" #1479
- I suspect there is no easy fix, maybe not a desired one.
- I would need some direction ;)
jrushlow
requested changes
Mar 16, 2024
There was a problem hiding this comment.
Thanks for the test @madflow - the problem is in Generator and ultimately in how we validate a class against the autoloader. I've created a PR #1482 with a similar test case and I'm working on a fix that, hopefully, doesnt require reverting #1422.
We'll more than likely get this merged in about the same time I'm able to work out a fix in #1482
jrushlow
added
Status: Needs Work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.