[make:entity] confirm to allow non-ascii char's in entity names #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fan2Shrek
force-pushed
the
better-accent-prevention
branch
2 times, most recently
from
749f523
to
8c49009
Compare
Fan2Shrek
changed the title
Fan2Shrek
force-pushed
the
better-accent-prevention
branch
from
8c49009
to
55c7189
Compare
jrushlow
approved these changes
May 19, 2024
There was a problem hiding this comment.
Thank you @Fan2Shrek - I've suggested a couple minor changes which I'll go ahead and commit so we can merge.
jrushlow
changed the title
jrushlow
reviewed
May 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the message #1474 (comment), I made some modifications
edited by @jrushlow
fixes #1556