Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:*] additional type improvements #1502

Merged
merged 2 commits into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Maker/AbstractMaker.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ protected function writeSuccessMessage(ConsoleStyle $io)
$io->newLine();
}

/** @param array<class-string, string> $dependencies */
protected function addDependencies(array $dependencies, ?string $message = null): string
{
$dependencyBuilder = new DependencyBuilder();
Expand Down
1 change: 1 addition & 0 deletions src/Maker/MakeListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
}
}

/** @return void */
public function configureDependencies(DependencyBuilder $dependencies)
{
}
Expand Down
3 changes: 2 additions & 1 deletion src/Maker/MakeMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public static function getCommandDescription(): string
return 'Create a new migration based on database changes';
}

/** @return void */
public function setApplication(Application $application)
{
$this->application = $application;
Expand All @@ -77,7 +78,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
;
}

/** @return void */
/** @return void|int */
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
{
$options = ['doctrine:migrations:diff'];
Expand Down
1 change: 1 addition & 0 deletions src/Maker/MakeRegistrationForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
}
}

/** @param array<string, mixed> $securityData */
private function interactAuthenticatorQuestions(ConsoleStyle $io, InteractiveSecurityHelper $interactiveSecurityHelper, array $securityData): void
{
// get list of authenticators
Expand Down
2 changes: 2 additions & 0 deletions src/Maker/MakeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ public static function getCommandName(): string

/**
* @deprecated remove this method when removing make:unit-test and make:functional-test
*
* @return string[]
*/
public static function getCommandAliases(): iterable
{
Expand Down
Loading