[make:entity] Simplify repository PHPDoc removes method annotations #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
changed the title
jrushlow
changed the title
jrushlow
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Awesome! I'm about 99% sure that we are safe to remove the annotations now. Some SymfonyCasts folks and I tried out code completion in PHPStorm and it appears to be working just fine without them...
I'm sure the folks out there with the pitch forks will let us know pretty quick if this does break something after cutting a release. 😄
stof
approved these changes
Apr 24, 2024
|
On my end this PR broke autocompletion on PHPStorm on projects with ORM 2 (didn't tried with 3) |
|
This is really weird, because we tested it with ORM2 and it was okay. |
|
|
|
@simondaigre - Yes if you could create a new issue - I'll get a patch out in the next day or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed theses from project project, and my IDE (vscode) and PHPStan are okay with that.
It works, because doctrine has already templated the methods