Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] Update ux-turbo package name to have proper suggestion #1535

Merged
merged 1 commit into from
May 7, 2024

Conversation

nfragnet
Copy link
Contributor

@nfragnet nfragnet commented May 4, 2024

Hi 👋

I tried to create an entity using bin/console make:entity --broadcast and got an error message suggesting a command to install the missing dependency. I think the command isn't working because the flex alias does not exist.

Capture d’écran 2024-05-04 à 12 48 04

I assumed that the correct dependency was symfony/ux-turbo and updated the MakeEntity class to declare the correct package name.

@nfragnet nfragnet changed the title fix: Update ux-turbo package name to have proper suggestion in MakeEntity command minor [make:entity] Update ux-turbo package name to have proper suggestion May 4, 2024
@nfragnet nfragnet changed the title minor [make:entity] Update ux-turbo package name to have proper suggestion [make:entity] Update ux-turbo package name to have proper suggestion May 4, 2024
@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels May 6, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfragnet - Thank you!

I'm not sure why the flex alias isn't working, but regardless, we're shifting to using the entire package name here in maker bundle rather than rely on flex aliases - so this is perfect.

Note to future self, we should utilize

public function installDependencyIfNeeded(ConsoleStyle $io, string $expectedClassToExist, string $composerPackage): ConsoleStyle
for ux-turbo and api bundles instead of throwing an error. This would behave like:
$this->installDependencyIfNeeded(

If you're up for that @nfragnet task, a PR would be much appreciated.

@jrushlow jrushlow added this to the v1.60.0 milestone May 6, 2024
@jrushlow jrushlow merged commit 72a9d7b into symfony:main May 7, 2024
7 checks passed
@jrushlow jrushlow mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants