Do not remove escaping on TwigFilter by default #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new TwigFilter('filter_name', [$this, 'doSomething'], ['is_safe' => ['html']]), | ||
| // If your filter generates SAFE HTML, you should add a third | ||
| // parameter: ['is_safe' => ['html']] | ||
| // Reference: https://twig.symfony.com/doc/2.x/advanced.html#automatic-escaping |
There was a problem hiding this comment.
Or add an --safe-html option on the command? Such comments will be committed usually, thus be noise to many lazy fools (all of us ;) )
There was a problem hiding this comment.
Almost all code generated by this bundle should be updated by the end user. So I prefer to not add a new option
For example the callback on the next line should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #200