fix MakerEntity when generating entity inside folder #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, awesome diagnosis and fix! This rocks! I added a failing test case which confirmed the bug (and your patch DOES fix it of course). Great PR - thank you Nicolas! I hope to see you back for some more PR's ;) |
weaverryan
added a commit
that referenced
this pull request
Aug 29, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- fix MakerEntity when generating entity inside folder fixes #192 When we're trying to generate an entity inside a folder, and when the namespace of the newly created correspond to an entity that already exists, an error occurs : > In MakeEntity.php line 840: > Call to a member function getName() on string Ex : An entity called App\Entity\BlogPost exists, and we try to create an entity named "BlogPost\Comment" Actually `Str::getNamespace($className)` refers to an existing class and not to a namespace, then $doctrineHelper->getMetadata() won't return an array, but a single metadata, and this leads to an error. To prevent this behavior, the easier way is to put a trailing backslash at the end of the namespace name, so we know it won't refer to a classname. Commits ------- 535c805 fix MakerEntity when generating entity inside folder
|
haha thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #192
When we're trying to generate an entity inside a folder, and when the namespace of the newly created correspond to an entity that already exists, an error occurs :
Ex :
An entity called App\Entity\BlogPost exists, and we try to create an entity named "BlogPost\Comment"
Actually
Str::getNamespace($className)refers to an existing class and not to a namespace, then $doctrineHelper->getMetadata() won't return an array, but a single metadata, and this leads to an error.To prevent this behavior, the easier way is to put a trailing backslash at the end of the namespace name, so we know it won't refer to a classname.