Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error message style on invalid class name #37

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Nov 22, 2017

before
invalid-class-name-bad

after
valid-class-name-good

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks!

@javiereguiluz javiereguiluz merged commit 2930e3c into symfony:master Nov 22, 2017
javiereguiluz added a commit that referenced this pull request Nov 22, 2017
This PR was merged into the 1.0-dev branch.

Discussion
----------

Improving error message style on invalid class name

**before**
![invalid-class-name-bad](https://user-images.githubusercontent.com/2028198/33103664-a044d53c-cef1-11e7-985c-33e36e0d28a7.png)

**after**
![valid-class-name-good](https://user-images.githubusercontent.com/2028198/33103682-b87b10ee-cef1-11e7-9bfc-4c0b51889f1c.png)

Commits
-------

2930e3c Improving error message style on invalid class name
@yceruto yceruto deleted the better_exception_output branch November 22, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants