Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use attributes for API Platform when using PHP 8+ #859

Merged
merged 1 commit into from
Apr 8, 2021
Merged

use attributes for API Platform when using PHP 8+ #859

merged 1 commit into from
Apr 8, 2021

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Apr 3, 2021

No description provided.

jrushlow
jrushlow requested changes Apr 5, 2021
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/tmp/.gitignore has to stay :)

@jrushlow jrushlow added Status: Needs Work Additional work is needed Related Tests Pass labels Apr 5, 2021
@dunglas
Copy link
Member Author

dunglas commented Apr 5, 2021

@jrushlow Oops, fixed!

jrushlow
jrushlow approved these changes Apr 5, 2021
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dunglas!

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Work Additional work is needed labels Apr 5, 2021
@weaverryan
Copy link
Member

Thanks Kévin!

@weaverryan weaverryan merged commit e3e3c61 into symfony:main Apr 8, 2021
@dunglas dunglas deleted the api-p/attributes branch April 8, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Related Tests Pass Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @weaverryan @jrushlow