Renaming variable $userPasswordHasherInterface -> $userPasswordHasher #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 12, 2021
OskarStark
approved these changes
Oct 13, 2021
weaverryan
force-pushed
the
password_variable_name_fix
branch
from
287bbc2 to
48db30d
Compare
weaverryan
force-pushed
the
password_variable_name_fix
branch
from
48db30d to
39abf21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (by removing
Interface) an unnecessarily long and strange argument name in the controller. Before:Already tested in a real app to be extra safe :)