Lazy loaded Twig Extension

[qdequippe]

https://symfony.com/doc/8.0/templates.html#templates-twig-extension

[GromNaN]

Removing a public method from a class is a breaking change, but I think we can make it of the next 0.minor version.

The extension attributes added in Twig 3.21.0 allows to create lazy extension with a single class. I recommend this approach.

The MercureBundle must also be updated to enable autoconfiguration (or add both twig.attribute_extension and twig.runtime tags): https://github.com/symfony/mercure-bundle/blob/main/src/DependencyInjection/MercureExtension.php#L270-L274

[GromNaN]

You could keep this function in this class and use the #[TwigFunction] attribute to make this extension lazy.

[qdequippe]

Do I need also to remove this config from the bundle? https://github.com/symfony/mercure-bundle/blob/main/src/DependencyInjection/MercureExtension.php#L270-L274

[Kocal]

Hi!

Unfortunately it brokes Symfony UX test suite, see symfony/ux#3185:

Caused by
Error: Call to undefined method Twig\Extension\AttributeExtension::mercure()

/Users/kocal/workspace-os/symfony-ux/src/Turbo/src/Bridge/Mercure/TurboStreamListenRenderer.php:74
/Users/kocal/workspace-os/symfony-ux/src/Turbo/src/Twig/TurboRuntime.php:56
/Users/kocal/workspace-os/symfony-ux/src/Turbo/tests/app/var/cache/test/twig/a6/a6bf9eb373b97e9f3553121cb9f84f50.php:48
/Users/kocal/workspace-os/symfony-ux/src/Turbo/vendor/twig/twig/src/Template.php:402
/Users/kocal/workspace-os/symfony-ux/src/Turbo/vendor/twig/twig/src/Template.php:358
/Users/kocal/workspace-os/symfony-ux/src/Turbo/vendor/twig/twig/src/Template.php:373
/Users/kocal/workspace-os/symfony-ux/src/Turbo/vendor/twig/twig/src/TemplateWrapper.php:51
/Users/kocal/workspace-os/symfony-ux/src/Turbo/tests/Bridge/Mercure/TurboStreamListenRendererTest.php:30

How can we migrate this code?

$mercure = $this->twig->getExtension(MercureExtension::class);
if ($eventSourceOptions['withCredentials'] ?? false) {
    $eventSourceOptions['subscribe'] ??= $topics;
    $controllerAttributes['withCredentials'] = true;
}
$mercure->mercure($topics, $eventSourceOptions);

Thanks!

[GromNaN]

@Kocal the MercureExtension is now registered as a Twig runtime.

[Kocal]

Thanks!