Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split configuration #432

Merged
merged 2 commits into from
May 10, 2022
Merged

Split configuration #432

merged 2 commits into from
May 10, 2022

Conversation

raziel057
Copy link
Contributor

For better readability and to fix #412
As proposed here #412 (comment)

Workarround for PHP issue php/php-src#8315

For better readability and to fix symfony#412
As proposed here symfony#412 (comment)

Workarround for PHP issue php/php-src#8315
@raziel057
Copy link
Contributor Author

raziel057 commented Apr 22, 2022

Failing tests for PHPUnit Test for PHP < 7.4 is not related to the Split of config but to

Remaining direct deprecation notices (1)

  1x: Since symfony/monolog-bridge 5.4: "Symfony\Bridge\Monolog\Handler\SwiftMailerHandler" is deprecated and will be removed in 6.0.
    1x in XmlMonologExtensionTest::testSingleEmailRecipient from Symfony\Bundle\MonologBundle\Tests\DependencyInjection

@raziel057
Copy link
Contributor Author

Hi there, it seems that the ticket on PHP side (marked as Feature php/php-src#8315) will not be resolved soon I propose to accept the following PR where the config is split in multiple sub parts to avoid to encounter the PHP issue.

@ahajzik-crido
Copy link

Could you process this PR? Even though we have production env on linux, we develop on windows. It is hard to work doing "cache:clear" almost every time we need to test changes. We can't live long time with this issue. If it si not going to be solved we will be forced to abandon monolog logger.

@Seldaek
Copy link
Member

Seldaek commented May 10, 2022

Thanks - kinda hard to review all this code shifting, but I'm hoping you did it diligently :)

@Seldaek Seldaek merged commit 671482e into symfony:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants