Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHP 8.1 #496

Draft
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Draft

Bump to PHP 8.1 #496

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 9, 2024

Active support for Symfony 5.4 will end in November. After that we won't need to maintain codebases anymore that support PHP 7. This repository is full of code that targets PHP 7 exclusively which is why I believe it's worth considering that we drop PHP 7 support here as well as soon as the maintenance of Symfony 5.4 is over.

This PR demonstrates the amount of code that we could get rid of. I'm flagging the PR as draft for the time being because I believe we don't want to merge it before November.

@stof
Copy link
Member

stof commented Sep 10, 2024

The Symfony 5.4 EOL is only in 1 year. Making the 5.4 LTS depend on an unmaintained version of polyfills looks wrong to me.
I think the maintenance cost of the polyfills for PHP 7 is manageable for now, so we might want to delay this PR until next year when 5.4 is fully EOL. This could be less work than creating a LTS version for polyfills.

@derrabus
Copy link
Member Author

The Symfony 5.4 EOL is only in 1 year.

The active support for PHP 5.4 ends this year in November. Beyond that is pure security fixing and all non-critical bugs become permanent features.

Making the 5.4 LTS depend on an unmaintained version of polyfills looks wrong to me.

I'm happy to provide equal level of support to the polyfills which would mean we backport security fixes to the last tag that was compatible with PHP 7. I don't expect much to come here.

I think the maintenance cost of the polyfills for PHP 7 is manageable for now

I mean, look at all the code I'm deleting here. Managable? Yes, but managaging this stuff comes with a price tag.

@derrabus derrabus force-pushed the drop/php-7 branch 2 times, most recently from 139d226 to b8de37e Compare September 17, 2024 09:49
@stof
Copy link
Member

stof commented Sep 17, 2024

I mean, look at all the code I'm deleting here. Managable? Yes, but managaging this stuff comes with a price tag.

How often have you modified that code in the last year ?

@derrabus
Copy link
Member Author

derrabus commented Sep 17, 2024

How often have you modified that code in the last year ?

It's more like, how often do we add new polyfills and have to jump through more hoops to get the support PHP 7 right. See #499/#501: We're fixing new polyfills for PHP 7 here that Symfony 5 itself does not even use. That's fine now, but once Symfony itself does not support PHP 7 anymore, this really feels like a pointless endeavor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants