Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbstring: Fix mb_rtrim() for UTF-8 text #507

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

nsfisis
Copy link
Contributor

@nsfisis nsfisis commented Nov 4, 2024

Component

Polyfill-mbstring

Problem

mb_rtrim() returns an empty string for UTF-8 text.

How to Reproduce

echo \Symfony\Polyfill\Mbstring\Mbstring::mb_rtrim(' あいうえお ');
// => '' (empty string)

Expected result: ' あいうえお'

Cause

The regular expression used in mb_rtrim() implementation does not have u flag.

Changes

  • Add u flag to the regular expression used in mb_rtrim() implementation as mb_trim() and mb_ltrim() do.
  • Add tests.

@GromNaN
Copy link
Member

GromNaN commented Dec 22, 2024

Thank you @nsfisis.

@GromNaN GromNaN merged commit d7e262e into symfony:1.x Dec 22, 2024
2 of 9 checks passed
@nsfisis nsfisis deleted the fix/mb_rtrim branch December 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants