Skip to content

[FEAT] Add Docker config on rossel-kafka recipe #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fvaneste-rossel
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) April 4, 2025 14:20
Copy link

github-actions bot commented Apr 4, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1774/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1774/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'rossel/rossel-kafka:^0.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled April 4, 2025 14:21

Head branch was pushed to by a user without write access

@fvaneste-rossel fvaneste-rossel force-pushed the feat/add-docker-configuration-on-rossel-kafka-recipe branch from e43f179 to db34933 Compare April 4, 2025 14:21
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) April 4, 2025 14:22
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .idea directory, personal IDE configuration shouldn't be added to recipes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the .idea folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants