Skip to content

Commit

Permalink
[symfony/panther] leverage the new add-lines configurator (#1215)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolas-grekas authored Jun 19, 2023
1 parent 356ad03 commit dfe6f33
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 19 deletions.
4 changes: 0 additions & 4 deletions phpunit/phpunit/4.7/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
4 changes: 0 additions & 4 deletions phpunit/phpunit/9.3/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
8 changes: 8 additions & 0 deletions symfony/panther/1.0/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,13 @@
"#RUN wget -q https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz; \\",
"#\ttar -zxf geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz -C /usr/bin; \\",
"#\trm geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz"
],
"add-lines": [
{
"file": "phpunit.xml.dist",
"content": " <extension class=\"Symfony\\Component\\Panther\\ServerExtension\" />",
"position": "after_target",
"target": "<extensions>"
}
]
}
3 changes: 0 additions & 3 deletions symfony/panther/1.0/post-install.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@
<fg=green>vendor/bin/bdi detect drivers</>

This step is not necessary when using Docker.

* To use Panther with PHPUnit,
uncomment the snippet registering the Panther extension in <fg=green>phpunit.xml.dist</>
4 changes: 0 additions & 4 deletions symfony/phpunit-bridge/5.1/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
4 changes: 0 additions & 4 deletions symfony/phpunit-bridge/5.3/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>

0 comments on commit dfe6f33

Please sign in to comment.