Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symfony/panther] leverage the new add-lines configurator #1215

Merged
merged 1 commit into from
Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions phpunit/phpunit/4.7/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
4 changes: 0 additions & 4 deletions phpunit/phpunit/9.3/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
8 changes: 8 additions & 0 deletions symfony/panther/1.0/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,13 @@
"#RUN wget -q https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz; \\",
"#\ttar -zxf geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz -C /usr/bin; \\",
"#\trm geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz"
],
"add-lines": [
{
"file": "phpunit.xml.dist",
"content": " <extension class=\"Symfony\\Component\\Panther\\ServerExtension\" />",
"position": "after_target",
"target": "<extensions>"
}
]
}
3 changes: 0 additions & 3 deletions symfony/panther/1.0/post-install.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@
<fg=green>vendor/bin/bdi detect drivers</>

This step is not necessary when using Docker.

* To use Panther with PHPUnit,
uncomment the snippet registering the Panther extension in <fg=green>phpunit.xml.dist</>
4 changes: 0 additions & 4 deletions symfony/phpunit-bridge/5.1/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>
4 changes: 0 additions & 4 deletions symfony/phpunit-bridge/5.3/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>

<!-- Run `composer require symfony/panther` before enabling this extension -->
<!--
<extensions>
<extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
-->
</phpunit>