-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX LazyImage] Add initial recipe #1319
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/ux-lazy-image2.17 vs 2.18diff --git a/symfony/ux-lazy-image/2.17/config/packages/lazy_image.yaml b/symfony/ux-lazy-image/2.18/config/packages/lazy_image.yaml
index c701d01..0ea8aa9 100644
--- a/symfony/ux-lazy-image/2.17/config/packages/lazy_image.yaml
+++ b/symfony/ux-lazy-image/2.18/config/packages/lazy_image.yaml
@@ -1,4 +1,9 @@
# lazy_image:
+ # By default, images are fetched through "file_get_contents" function, but you can use your own implementation
+ # with an invokable service or a callable.
+ # https://symfony.com/bundles/ux-lazy-image/current/index.html#customizing-images-fetching
+ # fetch_image_content: 'App\BlurHash\FetchImageContent'
+
# It is recommended to cache the generated BlurHash for performance reasons, to avoid generating it for each request.
# https://symfony.com/bundles/ux-lazy-image/current/index.html#performance-considerations
# cache: cache.lazy_image |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
# By default, images are fetch through "file_get_contents" function, but you can use your own implementation | ||
# with an invokable service or a callable. | ||
# https://symfony.com/bundles/ux-lazy-image/current/index.html#customizing-images-fetching | ||
# fetch_image_content: 'App\BlurHash\FetchImageContent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.18 is not released yet, but it will ship symfony/ux#1781
Head branch was pushed to by a user without write access
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Hi everyone, this PR adds the recipe for
symfony/ux-lazy-image
.It does not configure anything, instead it gives some hints about the bundle possibilities :)