Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose for doctrine/doctrine-bundle@2.13 #1366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docker-compose for doctrine/doctrine-bundle@2.13 #1366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doctrine/doctrine-bundle/2.13/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
" environment:",
" POSTGRES_DB: ${POSTGRES_DB:-app}",
" # You should definitely change the password in production",
" POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-!ChangeMe!}",
" POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-\"!ChangeMe!\"}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that the problem comes from the ! char? Weirdly, we never had this problem before.

Anyway, what about making it simpler like (cc @dunglas):

Suggested change
" POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-\"!ChangeMe!\"}",
" POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-ChangeMe}",

" POSTGRES_USER: ${POSTGRES_USER:-app}",
" healthcheck:",
" test: [\"CMD\", \"pg_isready\", \"-d\", \"${POSTGRES_DB:-app}\", \"-U\", \"${POSTGRES_USER:-app}\"]",
Expand Down
Loading