Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flex/2.4] Add missing .env.dev file #1367

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[flex/2.4] Add missing .env.dev file #1367

merged 1 commit into from
Dec 4, 2024

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR -

Otherwise flex cannot populate it with APP_SECRET

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 4, 2024 10:14
Copy link

github-actions bot commented Dec 4, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1367/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1367/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'symfony/flex:^2.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/flex

1.0 vs 2.4
diff --git a/symfony/flex/2.4/.env.dev b/symfony/flex/2.4/.env.dev
new file mode 100644
index 0000000..e69de29
diff --git a/symfony/flex/1.0/manifest.json b/symfony/flex/2.4/manifest.json
index 56f64a6..008fd44 100644
--- a/symfony/flex/1.0/manifest.json
+++ b/symfony/flex/2.4/manifest.json
@@ -1,5 +1,6 @@
 {
     "copy-from-recipe": {
-        ".env": ".env"
+        ".env": ".env",
+        ".env.dev": ".env.dev"
     }
 }

@nicolas-grekas nicolas-grekas changed the title [framework-bundle/7.2] Add missing .env.dev file [flex/2.4] Add missing .env.dev file Dec 4, 2024
@nicolas-grekas nicolas-grekas merged commit dc8a1b5 into main Dec 4, 2024
1 of 2 checks passed
@nicolas-grekas nicolas-grekas deleted the env-dev branch December 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant