Remove calls to getMockForAbstractClass()

symfony · May 15, 2024 · 49c9c6d · 49c9c6d
1 parent 42a12aa
commit 49c9c6d
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 34 deletions.
diff --git a/Tests/EventListener/PasswordMigratingListenerTest.php b/Tests/EventListener/PasswordMigratingListenerTest.php
@@ -108,7 +108,7 @@ public function testUnsupportedPassport()
 
     public function testUpgradeWithUpgrader()
     {
-        $passwordUpgrader = $this->getMockForAbstractClass(TestMigratingUserProvider::class);
+        $passwordUpgrader = $this->createMock(TestMigratingUserProvider::class);
         $passwordUpgrader->expects($this->once())
             ->method('upgradePassword')
             ->with($this->user, 'new-hash')
@@ -120,7 +120,7 @@ public function testUpgradeWithUpgrader()
 
     public function testUpgradeWithoutUpgrader()
     {
-        $userLoader = $this->getMockForAbstractClass(TestMigratingUserProvider::class);
+        $userLoader = $this->createMock(TestMigratingUserProvider::class);
         $userLoader->expects($this->any())->method('loadUserByIdentifier')->willReturn($this->user);
 
         $userLoader->expects($this->exactly(2))

diff --git a/Tests/Firewall/AbstractPreAuthenticatedListenerTest.php b/Tests/Firewall/AbstractPreAuthenticatedListenerTest.php
@@ -56,11 +56,15 @@ public function testHandleWithValidValues()
             ->willReturn($token)
         ;
 
-        $listener = $this->getMockForAbstractClass(AbstractPreAuthenticatedListener::class, [
-            $tokenStorage,
-            $authenticationManager,
-            'TheProviderKey',
-        ]);
+        $listener = $this->getMockBuilder(AbstractPreAuthenticatedListener::class)
+            ->setConstructorArgs([
+                $tokenStorage,
+                $authenticationManager,
+                'TheProviderKey',
+            ])
+            ->onlyMethods(['getPreAuthenticatedData'])
+            ->getMock();
+
         $listener
             ->expects($this->once())
             ->method('getPreAuthenticatedData')
@@ -95,12 +99,15 @@ public function testHandleWhenAuthenticationFails()
             ->willThrowException($exception)
         ;
 
-        $listener = $this->getMockForAbstractClass(
-            AbstractPreAuthenticatedListener::class, [
-            $tokenStorage,
-            $authenticationManager,
-            'TheProviderKey',
-        ]);
+        $listener = $this->getMockBuilder(AbstractPreAuthenticatedListener::class)
+            ->setConstructorArgs([
+                $tokenStorage,
+                $authenticationManager,
+                'TheProviderKey',
+            ])
+            ->onlyMethods(['getPreAuthenticatedData'])
+            ->getMock();
+
         $listener
             ->expects($this->once())
             ->method('getPreAuthenticatedData')
@@ -137,12 +144,15 @@ public function testHandleWhenAuthenticationFailsWithDifferentToken()
             ->willThrowException($exception)
         ;
 
-        $listener = $this->getMockForAbstractClass(
-            AbstractPreAuthenticatedListener::class, [
-            $tokenStorage,
-            $authenticationManager,
-            'TheProviderKey',
-        ]);
+        $listener = $this->getMockBuilder(AbstractPreAuthenticatedListener::class)
+            ->setConstructorArgs([
+                $tokenStorage,
+                $authenticationManager,
+                'TheProviderKey',
+            ])
+            ->onlyMethods(['getPreAuthenticatedData'])
+            ->getMock();
+
         $listener
             ->expects($this->once())
             ->method('getPreAuthenticatedData')
@@ -174,12 +184,15 @@ public function testHandleWithASimilarAuthenticatedToken()
             ->method('authenticate')
         ;
 
-        $listener = $this->getMockForAbstractClass(
-            AbstractPreAuthenticatedListener::class, [
-            $tokenStorage,
-            $authenticationManager,
-            'TheProviderKey',
-        ]);
+        $listener = $this->getMockBuilder(AbstractPreAuthenticatedListener::class)
+            ->setConstructorArgs([
+                $tokenStorage,
+                $authenticationManager,
+                'TheProviderKey',
+            ])
+            ->onlyMethods(['getPreAuthenticatedData'])
+            ->getMock();
+
         $listener
             ->expects($this->once())
             ->method('getPreAuthenticatedData')
@@ -217,12 +230,15 @@ public function testHandleWithAnInvalidSimilarToken()
             ->willThrowException($exception)
         ;
 
-        $listener = $this->getMockForAbstractClass(
-            AbstractPreAuthenticatedListener::class, [
-            $tokenStorage,
-            $authenticationManager,
-            'TheProviderKey',
-        ]);
+        $listener = $this->getMockBuilder(AbstractPreAuthenticatedListener::class)
+            ->setConstructorArgs([
+                $tokenStorage,
+                $authenticationManager,
+                'TheProviderKey',
+            ])
+            ->onlyMethods(['getPreAuthenticatedData'])
+            ->getMock();
+
         $listener
             ->expects($this->once())
             ->method('getPreAuthenticatedData')

diff --git a/Tests/RememberMe/AbstractRememberMeServicesTest.php b/Tests/RememberMe/AbstractRememberMeServicesTest.php
@@ -298,9 +298,12 @@ protected function getService($userProvider = null, $options = [], $logger = nul
             $userProvider = $this->getProvider();
         }
 
-        return $this->getMockForAbstractClass(AbstractRememberMeServices::class, [
-            [$userProvider], 'foosecret', 'fookey', $options, $logger,
-        ]);
+        return $this->getMockBuilder(AbstractRememberMeServices::class)
+            ->setConstructorArgs([
+                [$userProvider], 'foosecret', 'fookey', $options, $logger,
+            ])
+            ->onlyMethods(['processAutoLoginCookie', 'onLoginSuccess'])
+            ->getMock();
     }
 
     protected function getProvider()