Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/security-http
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.7
Choose a base ref
...
head repository: symfony/security-http
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.4.8
Choose a head ref
  • 6 commits
  • 5 files changed
  • 3 contributors

Commits on May 6, 2024

  1. Copy the full SHA
    31d24e4 View commit details

Commits on May 15, 2024

  1. Copy the full SHA
    49c9c6d View commit details
  2. minor #54785 Remove calls to TestCase::iniSet() and calls to deprec…

    …ated methods of `MockBuilder` (alexandre-daubois)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Issues        | -
    | License       | MIT
    
    Last round (before new deprecations 🙂). All deprecations [listed here](https://github.com/sebastianbergmann/phpunit/blob/main/DEPRECATIONS.md) should be gone.
    
    Commits
    -------
    
    4d5065ddd9 Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`
    xabbuh committed May 15, 2024
    Copy the full SHA
    1957999 View commit details

Commits on May 17, 2024

  1. Merge branch '5.4' into 6.4

    * 5.4:
      [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type
      Update security.nl.xlf
      [Validator] IBAN Check digits should always between 2 and 98
      [Security] Populate translations for trans-unit 20
      add missing plural translation messages
      filter out empty HTTP header parts
      [String] Fix folded in compat mode
      Remove calls to `getMockForAbstractClass()`
      [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode
      [Serializer] Fix type for missing property
      add test for JSON response with null as content
      [Filesystem] Fix dumpFile `stat failed` error hitting custom handler
      Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`
      [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10
    fabpot committed May 17, 2024
    Copy the full SHA
    aae96d3 View commit details

Commits on May 31, 2024

  1. Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"

    This reverts commit 2c9352dd91ebaf37b8a3e3c26fd8e1306df2fb73, reversing
    changes made to 18c3e87f1512be2cc50e90235b144b13bc347258.
    fabpot committed May 31, 2024
    Copy the full SHA
    7194820 View commit details
  2. Merge branch '5.4' into 6.4

    * 5.4:
      Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
    fabpot committed May 31, 2024
    Copy the full SHA
    fb82dde View commit details
3 changes: 2 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/Tests export-ignore
/phpunit.xml.dist export-ignore
/.git* export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
8 changes: 0 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

37 changes: 0 additions & 37 deletions .github/workflows/check-subtree-split.yml

This file was deleted.

4 changes: 2 additions & 2 deletions Tests/EventListener/PasswordMigratingListenerTest.php
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@ public static function provideUnsupportedEvents()

public function testUpgradeWithUpgrader()
{
$passwordUpgrader = $this->getMockForAbstractClass(TestMigratingUserProvider::class);
$passwordUpgrader = $this->createMock(TestMigratingUserProvider::class);
$passwordUpgrader->expects($this->once())
->method('upgradePassword')
->with($this->user, 'new-hash')
@@ -81,7 +81,7 @@ public function testUpgradeWithUpgrader()

public function testUpgradeWithoutUpgrader()
{
$userLoader = $this->getMockForAbstractClass(TestMigratingUserProvider::class);
$userLoader = $this->createMock(TestMigratingUserProvider::class);
$userLoader->expects($this->any())->method('loadUserByIdentifier')->willReturn($this->user);

$userLoader->expects($this->exactly(2))
7 changes: 5 additions & 2 deletions Tests/Firewall/ContextListenerTest.php
Original file line number Diff line number Diff line change
@@ -307,8 +307,11 @@ public function testWithPreviousNotStartedSession()

public function testSessionIsNotReported()
{
$usageReporter = $this->getMockBuilder(\stdClass::class)->addMethods(['__invoke'])->getMock();
$usageReporter->expects($this->never())->method('__invoke');
$this->expectNotToPerformAssertions();

$usageReporter = static function (): void {
throw new \LogicException('This should not be called');
};

$session = new Session(new MockArraySessionStorage(), null, null, $usageReporter);