Skip to content

Commit

Permalink
minor #6541 Trusted proxies were removed when URL signing took over (…
Browse files Browse the repository at this point in the history
…rawkode)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6541).

Discussion
----------

Trusted proxies were removed when URL signing took over

Since: symfony/http-kernel@fa8f4f8

Commits
-------

853825b Removing incorrect reference that the FragmentListener only listens to ``trusted_proxies``
  • Loading branch information
wouterj committed May 21, 2016
2 parents 7a3eca6 + 853825b commit 53af34b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions book/http_cache.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1207,11 +1207,6 @@ One great advantage of the ESI renderer is that you can make your application
as dynamic as needed and at the same time, hit the application as little as
possible.

.. tip::

The listener only responds to local IP addresses or
:doc:`trusted proxies </cookbook/request/load_balancer_reverse_proxy>`.

.. note::

Once you start using ESI, remember to always use the ``s-maxage``
Expand Down
2 changes: 1 addition & 1 deletion cookbook/request/load_balancer_reverse_proxy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ In this case, you'll need to - *very carefully* - trust *all* proxies.
$response = $kernel->handle($request);
// ...

#. Ensure that the trusted_proxies setting in your ``app/config/config.yml``
#. Ensure that the trusted_proxies setting in your ``app/config/config.yml``
is not set or it will overwrite the ``setTrustedProxies`` call above.

That's it! It's critical that you prevent traffic from all non-trusted sources.
Expand Down

0 comments on commit 53af34b

Please sign in to comment.