Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] Support for desktop notifications via jolicode/JoliNotif #20168

Closed
fabpot opened this issue Aug 27, 2024 · 3 comments
Closed

[Notifier] Support for desktop notifications via jolicode/JoliNotif #20168

fabpot opened this issue Aug 27, 2024 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Notifier
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Aug 27, 2024

Q A
Feature PR symfony/symfony#57683
PR author(s) @ahmedghanem00
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Aug 27, 2024
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Aug 27, 2024
@javiereguiluz
Copy link
Member

This is being done in #20076.

@OskarStark OskarStark mentioned this issue Aug 27, 2024
Merged
@ahmedghanem00
Copy link
Contributor

Thank you, This has been done in a separate PR as Javier has explained.

javiereguiluz added a commit that referenced this issue Aug 28, 2024
@javiereguiluz
minor #20076 [Notifier] Create DesktopChannel and JoliNotif bridg…
4203d31 
…e (ahmedghanem00)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Notifier] Create `DesktopChannel` and `JoliNotif` bridge

Updating docs according to symfony/symfony#57683

Fixes #20168

Commits
-------

45ba59f [Notifier] Create `DesktopChannel` and `JoliNotif` bridge
@javiereguiluz
Copy link
Member

Closing as fixed in #20076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Notifier
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @carsonbot @ahmedghanem00