Skip to content

Spellings #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bicpi opened this issue Nov 29, 2013 · 11 comments
Closed

Spellings #3237

bicpi opened this issue Nov 29, 2013 · 11 comments
Labels
Waiting feedback

Comments

@bicpi
Copy link
Contributor

bicpi commented Nov 29, 2013

Concerning the discussion in PR #3234 about the spelling of "e-mail/email/E-Mail" I've created a list of similiar spelling inconsistencies. If we agree on a notation I can update the docs. Please note that for some words the inconsistency is that they are used UC first or not (like stylesheet vs. Stylesheet). Of course, I don't mean the headings.

  • stylesheet - Stylesheet
  • front-end - frontend - front end
  • Full-Stack - Full stack
  • Symfony2 Framework - form framework - Form framework
  • Save-handler - Save handler
  • Dependeny Injection Tags - Dependeny Injection Container - dependeny injection container
  • Event Dispatcher - event dispatcher
  • Event Subscriber - event subscriber
  • Symfony2 Standard Distribution - Symfony2 Standard Edition
  • Console Command - console command
  • email - Email - e-mail
  • Boolean - boolean
  • web debug toolbar - Web Debug Toolbar
  • Exception - exception
  • object-oriented - object oriented
@wouterj
Copy link
Member

wouterj commented Nov 29, 2013

My thoughts:

  • stylesheet
  • front-end
  • full stack or full-stack PHP framework
  • Symfony2 Framework - Form component
  • Save handler
  • Dependency Injection Tags - Dependency Injection Container
  • EventDispatcher component - event dispatcher
  • event subscriber
  • Symfony2 Framework Standard Edition (it's the offical name)
  • console command - Command
  • e-mail
  • boolean (but the core uses Boolean, so let's use that...)
  • web debug toolbar
  • Exception class and throwing an exception
  • object-oriented

@bicpi
Copy link
Contributor Author

bicpi commented Nov 29, 2013

I did some research on this and here are my thoughts and some references:

  • style sheet (CSS specs: http://www.w3.org/Style/CSS)
  • front end (Wikipedia)
  • full stack or full-stack (no real reference; lowercase seems better)
  • Symfony2 Framework - Form component
  • save handler
  • Dependency Injection Tags - Dependency Injection Container
  • EventDispatcher component - event dispatcher
  • event subscriber
  • Symfony2 Framework Standard Edition (official name)
  • console command
  • email (Wikipedia, web in general, currently the most used in the docs)
  • Boolean (Wikipedia)
  • Exception class and throwing an exception
  • object-oriented (Wikipedia)

@bicpi bicpi mentioned this issue Dec 1, 2013
Closed
@javiereguiluz
Copy link
Member

It's sad that this issue didn't end up fixing all the inconsistencies. What if we reignite the discussion, resolve the pending doubts and start fixing the docs?

As we agree on almost everything, I will only add my thoughts about the different opinions between @bicpi and @wouterj:

  • to me, stylesheet looks much better than style sheet
  • in my opinion, front-end looks great, but front end is weird
  • Symfony2 Framework Standard Edition is too long. What about Symfony Standard Edition? That's the name we use in our trainings.

@wouterj
Copy link
Member

wouterj commented Sep 8, 2014

What about Symfony Standard Edition? That's the name we use in our trainings.

It's inconsistent with the package name
name: symfony/framework-standard-edition

@xabbuh
Copy link
Member

xabbuh commented Sep 8, 2014

Though "Symfony Standard Edition" is the name used for it in the repository docs.

@javiereguiluz
Copy link
Member

What could we do to give this issue the last boost that it needs before becoming a reality?

@bicpi
Copy link
Contributor Author

bicpi commented Dec 14, 2014

Can we agree on "Symfony Standard Edition"? It's shorter, more common and maybe "symfony/framework-standard-edition" becomes less important with the new Symfony installer.

I can then take of this issue and check the spelling list and possible variations from above against the docs.

@javiereguiluz
Copy link
Member

@bicpi it sounds great to me! @wouterj would you agree on "Symfony Standard Edition" term?

@xabbuh
Copy link
Member

xabbuh commented Dec 14, 2014

👍 for "Symfony Standard Edition"

I already started to work on this issue a couple of months ago. I try to finish it in the following week.

@wouterj
Copy link
Member

wouterj commented Dec 14, 2014

I don't mind that much, as long as it's consistent.

Btw, we should also rename the package to symfony/standard-edition imo

@xabbuh xabbuh mentioned this issue Dec 23, 2014
Merged
15 tasks
weaverryan added a commit that referenced this issue May 22, 2015
@weaverryan
minor #4671 consistent spelling (xabbuh)
0494129 
This PR was merged into the 2.3 branch.

Discussion
----------

consistent spelling

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | #3237

- [x] stylesheet - Stylesheet
- [x] front-end - frontend - front end
- [x] Full-Stack - Full stack
- [x] Symfony2 Framework - form framework - Form framework
- [x] Save-handler - Save handler
- [x] Dependeny Injection Tags - Dependeny Injection Container - dependeny injection container
- [x] Event Dispatcher - event dispatcher
- [x] Event Subscriber - event subscriber
- [x] Symfony2 Standard Distribution - Symfony2 Standard Edition
- [x] Console Command - console command
- [x] email - Email - e-mail
- [x] Boolean - boolean
- [x] web debug toolbar - Web Debug Toolbar
- [x] Exception - exception
- [x] object-oriented - object oriented

Commits
-------

f182121 uppercase "dependency injection"
6b7d536 use "Symfony Framework" instead of "Symfony framework"
07bc4db use "Form component" instead of "form framework"
bd5ca26 use "full-stack" instead of "full stack"
5b6895a unify exception usages
b774651 unify event subscriber usages
95c842c use "console command" instead of "Console Command"
9c02eda unify EventDispatcher/event dispatcher usages
fd52cd3 use boolean instead of Boolean
f8db4b0 use "object-oriented" instead of "object oriented"
1bd33ca "web debug toolbar" instead of "Web Debug Toolbar"
b2d802e use "stylesheet" instead of "Stylesheet"
7eb1847 unify "Symfony Standard Edition" usages
85fb0b1 consistency, replace "save-handler" with "save handler"
83238aa consisteny, use "front-end" instead of "frontend" or "front end"
5b8e84d consistency, replace "e-mail" with "email"
@weaverryan
Copy link
Member

I believe this can be closed now... so I'm doing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Waiting feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @weaverryan @bicpi @wouterj @xabbuh