Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Example does not follow RoleVoter api #3708

Closed
bystones opened this issue Mar 23, 2014 · 1 comment
Closed

[Security] Example does not follow RoleVoter api #3708

bystones opened this issue Mar 23, 2014 · 1 comment

Comments

@bystones
Copy link
Contributor

Hi,
the RoleVoter example in the docs (http://symfony.com/doc/current/components/security/authorization.html#rolevoter) uses vote with a string a third parameter. The api (http://api.symfony.com/2.4/Symfony/Component/Security/Core/Authorization/Voter/RoleVoter.html#method_vote) says the third parameter must be an array.
@bicpi bicpi mentioned this issue Mar 23, 2014
Merged
weaverryan added a commit that referenced this issue Mar 24, 2014
@weaverryan
bug #3709 [Components][Security] Fix #3708 (bicpi)
06c56c1 
This PR was merged into the 2.3 branch.

Discussion
----------

[Components][Security] Fix #3708

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #3708

Commits
-------

da025b1 [Components][Security] Fix #3708
@weaverryan
Copy link
Member

You're right! And thanks to @bicpi it's fixed!

Thanks @bystones so much for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @bystones