Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect SE changes #3748

Closed
wouterj opened this issue Apr 2, 2014 · 4 comments
Closed

Reflect SE changes #3748

wouterj opened this issue Apr 2, 2014 · 4 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone

Comments

@wouterj
Copy link
Member

wouterj commented Apr 2, 2014

As of 2.5, the SE doesn't come with the AcmeDemoBundle. You have to use the SensioDistributionBundle for that: symfony/symfony-standard#643

We should at least update the quick tour and maybe take a look at other places if we need to tell something about this or tweak the text a little bit.

@wouterj wouterj added this to the 2.5 milestone Apr 2, 2014
@cordoval
Copy link
Contributor

cordoval commented Apr 2, 2014

also let's add if possible the option to how to decouple form sensiodistribution to do our own distros i mean not project skeletons but distro packages rather than letting it be a bundle 👶

@fabpot
Copy link
Member

fabpot commented Apr 2, 2014

So, here are the changes:

  • When using create-project, Composer will ask you whether you want to install the demo bundle or not;
  • When depending on symfony/framework-standard-edition, the demo bundle is indeed not available anymore (but nobody should do that anyway)
  • When downloading a package from symfony.com, the demo bundle will still be available.

So, the impact is pretty minimal.

@wouterj
Copy link
Member Author

wouterj commented Apr 2, 2014

Thanks @fabpot That is indeed less than I thought. So what we have to do:

  • The quick tour should be updated to add info about the question whether you want the demo or not
  • Important places where we reference the Demo bundle, mostly the Book chapters, will need an update. For instance, "In the DemoBundle, you can see XXX" should be updated to "If you installed the DemoBundle, you can see XXX".

weaverryan added a commit that referenced this issue Jun 4, 2014
…(javiereguiluz)

This PR was merged into the 2.5 branch.

Discussion
----------

Updated the installation instructions for Symfony 2.5+

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes
| Applies to    | 2.5+
| Fixed tickets | #3748

Commits
-------

83bb723 Updated the installation instructions to Symfony 2.5+
@wouterj
Copy link
Member Author

wouterj commented Dec 13, 2014

Sicne #3874 fixed this and a new installer is introduced, I think it's valid to close this issue.

@wouterj wouterj closed this as completed Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Development

No branches or pull requests

3 participants