Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Clarify the difference between lists and maps #4509

Closed
xabbuh opened this issue Nov 21, 2014 · 3 comments
Closed

[Config] Clarify the difference between lists and maps #4509

xabbuh opened this issue Nov 21, 2014 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Config good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@xabbuh
Copy link
Member

xabbuh commented Nov 21, 2014

It seems that it is a bit unclear when the Config component processes an array node in the tree builder either as a map or as a list. Especially the effects of useAttributeAsKey() should be clarified (see symfony/symfony#12304 for the context).
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Config labels Nov 21, 2014
@xabbuh xabbuh mentioned this issue Nov 21, 2014
Closed
@wouterj wouterj self-assigned this Nov 22, 2014
@wouterj wouterj removed the good first issue Ideal for your first contribution! (some Symfony experience may be required) label Dec 17, 2014
@wouterj wouterj removed their assignment May 3, 2015
@wouterj wouterj added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label May 3, 2015
@wouterj
Copy link
Member

wouterj commented May 3, 2015

This should be done in components/config/definition

@javiereguiluz javiereguiluz mentioned this issue May 25, 2015
Merged
weaverryan added a commit that referenced this issue Oct 14, 2015
@weaverryan
feature #5314 Documented the useAttributeAsKey() method (javiereguiluz)
4d04ccf 
This PR was merged into the 2.3 branch.

Discussion
----------

Documented the useAttributeAsKey() method

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #4509

Two comments:

  * I've reordered the list of methods (addDefaultsIfNotSet, requiresAtLeastOneElement, useAttributeAsKey) to display it alphabetically and because it's better to have `useAttributeAsKey` at the end, just before showing the example.
  * I've left the XML code blocks empty and I'd like some XML expert to help me fill them.

Commits
-------

9fe9020 Fixed a minor syntax issue
e77c3b2 Rewritten the explanation about the useAttributeAsKey() method
0f8f9fd Documented the useAttributeAsKey() method
@vishalraj82
Copy link

I am using useAttributeAsKey, but could not find any way for the child keys to have only boolean values. Any help ?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 14, 2016

@vishalraj82 We only use GitHub to keep track of what needs to be done in the documentation. I suggest you use one of the support channels to reach out for help. Thank you for understanding.

@gingerCodeNinja gingerCodeNinja mentioned this issue Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Config good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weaverryan @vishalraj82 @wouterj @xabbuh