Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service scopes #5436

Closed
xabbuh opened this issue Jun 24, 2015 · 0 comments
Closed

Remove service scopes #5436

xabbuh opened this issue Jun 24, 2015 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@xabbuh
Copy link
Member

xabbuh commented Jun 24, 2015

Service scopes will officially be deprecated with Symfony 2.8 (see see symfony/symfony#14984). It needs to be checked if we have to update parts of the docs accordingly.
@xabbuh xabbuh mentioned this issue Jun 24, 2015
Closed
@wouterj wouterj added this to the 2.8 milestone Jun 24, 2015
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. DependencyInjection labels Jun 25, 2015
@javiereguiluz javiereguiluz mentioned this issue Jul 7, 2015
Merged
xabbuh added a commit that referenced this issue Jul 28, 2015
@xabbuh
minor #5498 [WIP] Added caution notes about the deprecation of contai…
43565d9 
…ner scopes (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

[WIP] Added caution notes about the deprecation of container scopes

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8+
| Fixed tickets | #5436

This is a first proposal related to scopes deprecation. Questions:

  * Should we expand the "caution notes" to explain why we did that and the alternatives provided?
  * Should we rewrite the `cookbook/service_container/scopes.rst` article to explain the new scopes + shared flag and add a note about the old scopes which were available in the past Symfony versions?

Commits
-------

99a996c Added caution notes about the deprecation of container scopes
This was referenced Nov 28, 2015
Merged
Closed
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Nov 28, 2015
weaverryan added a commit that referenced this issue Nov 30, 2015
@weaverryan
minor #5923 Remove information about request service deps of core ser…
c36dc2a 
…vices (WouterJ)

This PR was merged into the 2.7 branch.

Discussion
----------

Remove information about request service deps of core services

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.4+
| Fixed tickets | part of #5436

Services no longer depend on the request service, but instead on
request_stack so this is not an issue anymore as of Symfony 2.4.

Commits
-------

eeb579c Remove note about request service, which is not used anymore
179039b Remove information about request scpoe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@weaverryan @wouterj @xabbuh