Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main or default firewall ? #5878

Closed
flip111 opened this issue Nov 9, 2015 · 1 comment
Closed

main or default firewall ? #5878

flip111 opened this issue Nov 9, 2015 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security

Comments

@flip111
Copy link
Contributor

flip111 commented Nov 9, 2015

https://github.com/symfony/symfony-standard/blob/2.8/app/config/security.yml#L16

http://symfony.com/doc/current/book/security.html#a-configuring-how-your-users-will-authenticate

maybe the docs are out of date and default changed to main ?
@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2015

Thank you for reporting this @flip111. Technically, it is not important how we name the firewall. But it indeed would be easier to understand if we followed the same names as the code. So we should update our example(s).

@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 12, 2015
@javiereguiluz javiereguiluz mentioned this issue Nov 17, 2015
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Nov 20, 2015
xabbuh added a commit that referenced this issue Nov 28, 2015
@xabbuh
minor #5889 Always use "main" as the default firewall name (to match …
28c19e9 
…Symfony Standard Edition) (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Always use "main" as the default firewall name (to match Symfony Standard Edition)

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5878

Commits
-------

4ecfd2b Always use "main" as the default firewall name (to match Symfony Standard Edition)
@xabbuh xabbuh closed this as completed Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xabbuh @flip111