Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security-Acl] Missing docs (about updateUserSecurityIdentity() method) in 2.7, 2.8, 3.x series #6099

Closed
felipsmartins opened this issue Jan 3, 2016 · 1 comment
Closed

[Security-Acl] Missing docs (about updateUserSecurityIdentity() method) in 2.7, 2.8, 3.x series #6099

felipsmartins opened this issue Jan 3, 2016 · 1 comment
Labels
bug hasPR A Pull Request has already been submitted for this issue. Security

Comments

@felipsmartins
Copy link

Browsing on Symfony ACL related issues, I found this PR: #8650 ([Security][Acl] Add MutableAclProvider::updateUserSecurityIdentity) and its related documentation for new method: PR #3319

However, this doc update entry appears only in the doc pages of symfony 2.6 but not in 2.7, 2.8, 3.x doc pages. Look:

selecao_176

selecao_177

As this entry is an important note, why it was removed from documentation? Maybe a mistake? I've noticed "2.5 versionadded" has removed since this commit: Removed 2.5 versionadded as its deprecated
@xabbuh xabbuh mentioned this issue Jan 3, 2016
Merged
@xabbuh
Copy link
Member

xabbuh commented Jan 3, 2016

Thank you very much for spotting and reporting this issue @felipsmartins. You are right that we should keep this information (we always remove versionadded for EOLed versions in the master branch and sometimes, like with this one, we miss that there was more important information in them that we have to keep).

I opened #6100 to fix this.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 3, 2016
xabbuh added a commit that referenced this issue Jan 13, 2016
@xabbuh
minor #6100 [Cookbook][Security] add back updateUserSecurityIdentity(…
8815552 
…) hint (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Cookbook][Security] add back updateUserSecurityIdentity() hint

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | #6099

Commits
-------

466e404 add back updateUserSecurityIdentity() hint
@xabbuh xabbuh closed this as completed Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felipsmartins @xabbuh