Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change translation getMessages to replacement #6137

Closed
samsch opened this issue Jan 12, 2016 · 0 comments
Closed

Change translation getMessages to replacement #6137

samsch opened this issue Jan 12, 2016 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Translation
Milestone
2.8

Comments

@samsch
Copy link

samsch commented Jan 12, 2016

The getMessages method of Translator has been removed in 3.0, and depreciated in 2.8, but the docs need to be changed to reflect that.

The depreciation gives getCatalogue as a replacement, but they are not equivalent methods, so the example probably will need to be changed as well.

Quick link: http://symfony.com/doc/current/components/translation/usage.html#retrieving-the-message-catalogue
@xabbuh xabbuh added the actionable Clear and specific issues ready for anyone to take them. label Jan 12, 2016
@xabbuh xabbuh added this to the 2.8 milestone Jan 12, 2016
This was referenced Jan 19, 2016
Closed
Closed
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 20, 2016
@xabbuh xabbuh closed this as completed Feb 5, 2016
xabbuh added a commit that referenced this issue Feb 5, 2016
@xabbuh
minor #6170 change translation getMessages() to getCatalogue() (snoek09)
ab57eed 
This PR was squashed before being merged into the 2.8 branch (closes #6170).

Discussion
----------

change translation getMessages() to getCatalogue()

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #6137

I'm assuming here that the structure of the ``$messages`` variable didn't change.

Commits
-------

06ca405 change translation getMessages() to getCatalogue()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Translation
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @samsch