Skip to content

[Encore] Make title in FAQ more clear #10370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

royklutman
Copy link
Contributor

The current command in the bold text looks a little odd, because monospaced text can't be combined with bold text in RST:

image

It makes more sense to use double quotes:

image

See: https://symfony.com/doc/master/frontend/encore/faq.html#how-do-i-deploy-my-encore-assets

@royklutman royklutman changed the base branch from master to 3.4 September 20, 2018 11:26
@royklutman royklutman changed the title Use double quotes instead of monospace [Encore] Make title in FAQ more clear Sep 21, 2018
@javiereguiluz
Copy link
Member

Thank you Roy.

javiereguiluz added a commit that referenced this pull request Sep 21, 2018
This PR was squashed before being merged into the 3.4 branch (closes #10370).

Discussion
----------

[Encore] Make title in FAQ more clear

The current command in the bold text looks a little odd, because monospaced text can't be combined with bold text in RST:

![image](https://user-images.githubusercontent.com/14876024/45815287-75cb0f80-bcd8-11e8-933c-d67f61e82a15.png)

It makes more sense to use double quotes:

![image](https://user-images.githubusercontent.com/14876024/45815313-867b8580-bcd8-11e8-87ee-2115ae1154b7.png)

See: https://symfony.com/doc/master/frontend/encore/faq.html#how-do-i-deploy-my-encore-assets

Commits
-------

da34edd [Encore] Make title in FAQ more clear
@royklutman royklutman deleted the fix-code-in-title branch September 21, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants